Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: fix global scope #57174

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@tchernomax
Copy link
Contributor

commented May 30, 2019

SUMMARY

major rewrite of systemd.py

I start with #55936 but discovered that:

  1. I was wrong
  2. other parts of the code was also wrong

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

systemd

@tchernomax tchernomax force-pushed the tchernomax:systemd-global branch 2 times, most recently from 8eae939 to 6791555 May 30, 2019

@tchernomax tchernomax force-pushed the tchernomax:systemd-global branch from 6791555 to a6e72f1 May 30, 2019

@tchernomax

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

ping @bcoca

@bcoca bcoca self-assigned this May 30, 2019

@bcoca bcoca removed the needs_triage label May 30, 2019

@ansibot ansibot added the stale_ci label Jun 7, 2019

@tchernomax tchernomax force-pushed the tchernomax:systemd-global branch from a6e72f1 to a75839d Jun 16, 2019

@tchernomax tchernomax force-pushed the tchernomax:systemd-global branch from a75839d to ba5d5a0 Jun 18, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/system/systemd.py:428:73: undefined-variable Undefined variable 'systemctl_list_unit_files'
lib/ansible/modules/system/systemd.py:435:77: undefined-variable Undefined variable 'systemctl_list_unit_files'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/system/systemd.py:499:0: SyntaxWarning: 'str' object is not callable; perhaps you missed a comma?

click here for bot help

Maxime de Roucy
systemd: fix global scope
major rework

@tchernomax tchernomax force-pushed the tchernomax:systemd-global branch from ba5d5a0 to b50dfa0 Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.