Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eos test fix rollup #57180

Open
wants to merge 3 commits into
base: stable-2.7
from

Conversation

Projects
None yet
4 participants
@Qalthos
Copy link
Contributor

commented May 30, 2019

SUMMARY

Backports of fixes landed to 2.8 in an attempt to make 2.7 tests pass

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eos_eapi
eos_l2_interface

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@Qalthos, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

Qalthos and others added some commits May 28, 2019

[stable-2.8] eos_l2_interface handle "Interface does not exist" (#56787
…) (#56982)

* Add tests that should hopefully cover the error

* Fix warnings

* Add changelog

* Remove backport overreach

(cherry picked from commit 5a1985c)

* Fix 56787 for <=2.7
[stable-2.8] Don't validate ip address for mgmt interface (#56136)
It is possible the EOS appliance doesn't have an IP address on the
management1 interface, instead just check we have found that interface.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit f9589bd)

Co-authored-by: Paul Belanger <pabelanger@redhat.com>
[stable-2.8] Don't detect update if vrf not set. (#56235) (#56421)
* [stable-2.8] Don't detect update if vrf not set. (#56235)
(cherry picked from commit ea41bbc)
(cherry picked from commit 39c5758)

@Qalthos Qalthos force-pushed the Qalthos:eos_2.7 branch from ff4478a to 87d5c97 May 30, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@pabelanger
Copy link
Contributor

left a comment

This makes stable-2.7 green for eos network-integration jobs, for example:

https://dashboard.zuul.ansible.com/t/ansible/build/ad4a1387607d4e3db4956d73cf78f2d8

@ansibot ansibot removed the needs_triage label May 30, 2019

@Qalthos Qalthos marked this pull request as ready for review May 30, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

There's a discussion ongoing in the networking team to figure out whether we want to consider these things critical bugs or disable zuul on this subset of tests for stable-2.7. @Ikhan will discuss with me and we'll eventually either close this or try to merge all of these similar things for a single new 2.7.x release.

@ansibot ansibot added the stale_ci label Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.