Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_inventory: do not ignore validate_certs #57184

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@goneri
Copy link
Contributor

commented May 30, 2019

SUMMARY

Python 2.7.9 < does not have the ssl.SSLContext attribute. If
validate_certs is True, we cannot validate the SSL connection,
and we need to raise an error.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_inventory

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

contrib/inventory/vmware_inventory.py:349:16: undefined-variable Undefined variable 'module'

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

contrib/inventory/vmware_inventory.py:350:12: undefined-variable Undefined variable 'ssl_context'
contrib/inventory/vmware_inventory.py:358:12: undefined-variable Undefined variable 'ssl_context'

click here for bot help

vmware_inventory: do not ignore validate_certs
Python 2.7.9 < does not have the `ssl.SSLContext` attribute. If
`validate_certs` is `True`, we cannot validate the SSL connection,
and we need to raise an error.

@goneri goneri force-pushed the goneri:vmware_dont_ignore_validate_certs branch from 9b6db03 to 074b8f7 May 31, 2019

@goneri goneri requested a review from Akasurde May 31, 2019

@ansibot ansibot added the stale_ci label Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.