Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware: fix python 2.7.9 < with if validate_certs false #57185

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@goneri
Copy link
Contributor

commented May 30, 2019

SUMMARY

Python < 2.7.9 does not have the ssl.SSLContext attribute.
ssl.SSLContext is only required when we want to validate the SSL
connection. If validate_certs is false, we don't initialize the
ssl_context variable.

closes: #57072

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware

@ansibot

This comment has been minimized.

@goneri goneri force-pushed the goneri:vmware_no_sslcontext_with_validate_certs_false branch from d0fd26d to 1ad7d0c May 30, 2019

vmware: not ssl.SSLContext if validate_certs false
Python < 2.7.9 does not have the ssl.SSLContext attribute.
ssl.SSLContext is only required when we want to validate the SSL
connection. If `validate_certs` is false, we don't initialize the
`ssl_context` variable.

closes: #57072

@goneri goneri force-pushed the goneri:vmware_no_sslcontext_with_validate_certs_false branch from 1ad7d0c to 959bce6 May 31, 2019

@goneri goneri changed the title vmware: not ssl.SSLContext if validate_certs false vmware: fix python 2.7.9 < with if validate_certs false May 31, 2019

@Akasurde
Copy link
Member

left a comment

@goneri Could you please add unit test for this change ? Thanks.

@Akasurde Akasurde self-assigned this Jun 1, 2019

@Akasurde Akasurde requested a review from jillr Jun 1, 2019

@Akasurde Akasurde removed the needs_triage label Jun 1, 2019

@ansibot ansibot added the stale_ci label Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.