Skip to content

safe_eval fix #57188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2019
Merged

safe_eval fix #57188

merged 2 commits into from
Jun 6, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented May 30, 2019

fixes CVE-2019-10156

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

unsafe

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 30, 2019
@goneri goneri removed the needs_triage Needs a first human triage before being processed. label May 30, 2019
@ansibot

This comment has been minimized.

@ansibot ansibot added cloud docker test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 31, 2019
@ansibot
Copy link
Contributor

ansibot commented May 31, 2019

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels May 31, 2019
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 31, 2019
@ansibot ansibot added cisco Cisco technologies meraki Cisco Meraki community networking Network category postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. labels Jun 6, 2019
bcoca added 2 commits June 6, 2019 14:19
 - also fix globals
 - added tests
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Jun 6, 2019
@bcoca bcoca merged commit b9b0b23 into ansible:devel Jun 6, 2019
@bcoca bcoca deleted the unsafer branch June 6, 2019 19:36
bcoca added a commit to bcoca/ansible that referenced this pull request Jun 6, 2019
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23)
bcoca added a commit to bcoca/ansible that referenced this pull request Jun 6, 2019
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23)
bcoca added a commit to bcoca/ansible that referenced this pull request Jun 12, 2019
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23)
abadger pushed a commit that referenced this pull request Jun 17, 2019
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23)
abadger pushed a commit that referenced this pull request Jun 18, 2019
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23)
abadger pushed a commit that referenced this pull request Jun 21, 2019
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies cloud docker files Files category meraki Cisco Meraki community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants