Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed update_pgroup so that volumes get appended to volume members … #57199

Open

Conversation

Projects
None yet
3 participants
@bblanham
Copy link
Contributor

commented May 30, 2019

…list instead of replacing volume members list

SUMMARY

Fixes an issue when adding volumes to an existing protection group that has existing volume members, the list of new volumes would replace the existing protection group members instead of appending to the members list.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

purefa_pg

ADDITIONAL INFORMATION

Create a protection group (testpg) on your flash array and add a single volume (testvol1) to it
create second vol (testvol2) that ansible will use for adding to protection group
run the following ansible playbook task against that flash array:

  - name: Add volume to protection group
    purefa_pg:
      pgroup: testpg
      state: present
      volume:
        - testvol2

The protection group will end up having only testvol2 as a member.

The issue is related to the use of vollist parameter as opposed to the addvollist parameter provided as part of the flasharray API.

changed update_pgroup so that volumes get appended to volume members …
…list instead of replacing volume members list
@ansibot

This comment has been minimized.

@sdodsley
Copy link
Contributor

left a comment

What you are getting is by design.
How do we know that you want to add the new volume to existing volumes and not remove all volumes in the pgroup except the one you are listing?
We have to list all the volumes you want in the pgroup when calling update_pgroup, otherwise, the idempotency of the module is broken.

@ansibot ansibot removed the needs_triage label May 31, 2019

@ansibot ansibot added the stale_ci label Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.