Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test error for Azure devtestlab #57216

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@MyronFanQiu
Copy link
Contributor

commented May 31, 2019

SUMMARY

Because the behavior change of the Azure devtestlab service, the integration test will fail. Discussed with the service team to double-check and fix the integration test file to unblock the CI test.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_devtestlab

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

review_need

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@zikalino @yungezz @yuwzho Please review this PR when you have time! A PR with same content has been merged into the azure_preview_modules repo.

@yungezz

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

The change itself looks good. Just to double confirm, does this change need any module change/sample change?

@ansibot ansibot removed the needs_triage label Jun 19, 2019

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

The change itself looks good. Just to double confirm, does this change need any module change/sample change?

Yes. After the service team changing the behavior, I think policy_set_name field is useless in the azure_rm_devtestlabpolicy.yml. Because the error log is Error creating the Policy instance: Azure Error: CannotCreateAPolicyUnderNonDefaultPolicySet\nMessage: Policies can only be created under the default policy set..
I think we can create another PR to delete this one, but it will bring breaking change. The devtestlab SDK doesn't support multi-API versions. Or I can adjust the documentation and EXAMPLES to guide users fit into the new service behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.