Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to fix bug in nios member module #57218

Merged
merged 3 commits into from Jun 14, 2019

Conversation

Projects
None yet
4 participants
@krisvasudevan
Copy link
Contributor

commented May 31, 2019

SUMMARY

Cherry picked from (d998791)
Backport for PR #56045

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nios_member module

ADDITIONAL INFORMATION

Bug fixes for the nios member object (#56045)
* Bug fixes in api.py

* Examples updated in nios_member.py

* Update lib/ansible/module_utils/net_tools/nios/api.py

Co-Authored-By: Sumit Jaiswal <sjaiswal@redhat.com>

(cherry picked from commit d998791)
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

@krisvasudevan This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.
  • More than 50 commits.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@s-hertel s-hertel changed the base branch from devel to stable-2.8 Jun 6, 2019

@s-hertel

This comment has been minimized.

@krisvasudevan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@s-hertel I've added the changelog.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/56045-nios-member-module.yaml:0:0: section "bugfixes" list items must be type str not dict

click here for bot help

@@ -0,0 +1,2 @@
bugfixes:
- Bug fixes to nios_member module

This comment has been minimized.

Copy link
@abadger

abadger Jun 14, 2019

Member

Note that changelogs are meant for end users so it's better to tell people what the symptoms of the bug that's being fixed had. (Not a blocker for merge)

@abadger abadger merged commit 211a2da into ansible:stable-2.8 Jun 14, 2019

1 check passed

Shippable Run 127516 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.