Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: Add hostname and subdomain parameters #57223

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@machacekondra
Copy link
Contributor

commented May 31, 2019

SUMMARY

This PR add two new parameters to kubevirt_vm module called hostname and subdomain to manage DNS of the VM.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

kubevirt_vm

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

hostname:
description:
- "Specifies the hostname of the virtual machine. If not specified, the hostname will be set to the name of the virtul machine, if dhcp or
cloud-init is configured properly."

This comment has been minimized.

Copy link
@pkliczewski

pkliczewski May 31, 2019

the hostname will be set either by dhcp, cloud-init if configured or virtual machine name will be used.

subdomain:
description:
- "If specified, the fully qualified virtual machine hostname will be hostname.subdomain.namespace.svc.cluster_domain. If not specified,
the virtual machine will not have a domainname at all. The DNS entry will resolve to the virtual machine, no matter if the virtual machine

This comment has been minimized.

Copy link
@pkliczewski

pkliczewski May 31, 2019

s/domainname/domain name

@ansibot ansibot removed the needs_triage label May 31, 2019

@machacekondra machacekondra force-pushed the machacekondra:hostname_subdomain branch from e253151 to bc31e23 May 31, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/doc_fragments/kubevirt_common_options.py:111:161: E501 line too long (166 > 160 characters)

click here for bot help

@machacekondra machacekondra force-pushed the machacekondra:hostname_subdomain branch from bc31e23 to 1f7c57a Jun 3, 2019

@ansibot ansibot removed the ci_verified label Jun 3, 2019

@machacekondra machacekondra force-pushed the machacekondra:hostname_subdomain branch from 1f7c57a to b4f1e3c Jun 3, 2019

@ansibot ansibot added the stale_ci label Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.