Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge: test runner with ara #57231

Closed
wants to merge 1 commit into from
Closed

Conversation

@dmsimard
Copy link
Contributor

@dmsimard dmsimard commented May 31, 2019

Please ignore this pull request, would like to test if this works with shippable.
This is a redo of a previous similar pull request #51054.

@ansibot
Copy link
Contributor

@ansibot ansibot commented May 31, 2019

@ansibot
Copy link
Contributor

@ansibot ansibot commented May 31, 2019

The test ansible-test sanity --test test-constraints [explain] failed with 2 errors:

test/runner/requirements/integration.txt:7:7: put constraints in `test/runner/requirements/constraints.txt`
test/runner/requirements/integration.txt:8:20: put constraints in `test/runner/requirements/constraints.txt`

click here for bot help

@dmsimard
Copy link
Contributor Author

@dmsimard dmsimard commented Oct 28, 2019

I need to rebase this but couldn't figure out where the files had moved but @flowerysong pointed me in the right direction on #ansible-devel:

  • ansible = dict(
    ANSIBLE_PYTHON_MODULE_RLIMIT_NOFILE=str(SOFT_RLIMIT_NOFILE),
    ANSIBLE_FORCE_COLOR='%s' % 'true' if args.color and color else 'false',
    ANSIBLE_FORCE_HANDLERS='true', # allow cleanup handlers to run when tests fail
    ANSIBLE_HOST_PATTERN_MISMATCH='error', # prevent tests from unintentionally passing when hosts are not found
    ANSIBLE_INVENTORY='/dev/null', # force tests to provide inventory
    ANSIBLE_DEPRECATION_WARNINGS='false',
    ANSIBLE_HOST_KEY_CHECKING='false',
    ANSIBLE_RETRY_FILES_ENABLED='false',
    ANSIBLE_CONFIG=ansible_config,
    ANSIBLE_LIBRARY='/dev/null',
    PYTHONPATH=get_ansible_python_path(),
    PAGER='/bin/cat',
    PATH=path,
    )
  • https://github.com/ansible/ansible/blob/devel/test/lib/ansible_test/_data/requirements/integration.txt

@ansibot
Copy link
Contributor

@ansibot ansibot commented Oct 30, 2019

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

test/lib/ansible_test/_internal/executor.py:1461:36: bad-whitespace: Exactly one space required after comma             python_versions = ["3.6","3.7","3.8"]                                     ^
test/lib/ansible_test/_internal/executor.py:1461:42: bad-whitespace: Exactly one space required after comma             python_versions = ["3.6","3.7","3.8"]                                           ^
test/lib/ansible_test/_internal/executor.py:1462:29: bad-whitespace: No space allowed after bracket             callback_paths = [ "/usr/lib/python%s/site-packages/ara/plugins/callback" % version for version in python_versions ]                              ^
test/lib/ansible_test/_internal/executor.py:1462:127: bad-whitespace: No space allowed before bracket             callback_paths = [ "/usr/lib/python%s/site-packages/ara/plugins/callback" % version for version in python_versions ]                                                                                                                                ^

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

test/lib/ansible_test/_internal/executor.py:1461:37: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1461:43: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1462:31: E201: whitespace after '['
test/lib/ansible_test/_internal/executor.py:1462:127: E202: whitespace before ']'

The test ansible-test sanity --test test-constraints [explain] failed with 2 errors:

test/lib/ansible_test/_data/requirements/integration.txt:6:4: put constraints in `test/lib/ansible_test/_data/requirements/constraints.txt`
test/lib/ansible_test/_data/requirements/network-integration.txt:7:4: put constraints in `test/lib/ansible_test/_data/requirements/constraints.txt`

click here for bot help

@ansibot
Copy link
Contributor

@ansibot ansibot commented Nov 4, 2019

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

test/lib/ansible_test/_internal/executor.py:1461:36: bad-whitespace: Exactly one space required after comma             python_versions = ["3.6","3.7","3.8"]                                     ^
test/lib/ansible_test/_internal/executor.py:1461:42: bad-whitespace: Exactly one space required after comma             python_versions = ["3.6","3.7","3.8"]                                           ^
test/lib/ansible_test/_internal/executor.py:1462:29: bad-whitespace: No space allowed after bracket             callback_paths = [ "/usr/lib/python%s/site-packages/ara/plugins/callback" % version for version in python_versions ]                              ^
test/lib/ansible_test/_internal/executor.py:1462:127: bad-whitespace: No space allowed before bracket             callback_paths = [ "/usr/lib/python%s/site-packages/ara/plugins/callback" % version for version in python_versions ]                                                                                                                                ^

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

test/lib/ansible_test/_internal/executor.py:1461:37: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1461:43: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1462:31: E201: whitespace after '['
test/lib/ansible_test/_internal/executor.py:1462:127: E202: whitespace before ']'

The test ansible-test sanity --test test-constraints [explain] failed with 2 errors:

test/lib/ansible_test/_data/requirements/integration.txt:6:4: put constraints in `test/lib/ansible_test/_data/requirements/constraints.txt`
test/lib/ansible_test/_data/requirements/network-integration.txt:7:4: put constraints in `test/lib/ansible_test/_data/requirements/constraints.txt`

click here for bot help

@ansibot
Copy link
Contributor

@ansibot ansibot commented Sep 19, 2020

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

test/lib/ansible_test/_internal/executor.py:1459:32: bad-whitespace: Exactly one space required after comma         python_versions = ["3.6","3.7","3.8"]                                 ^
test/lib/ansible_test/_internal/executor.py:1459:38: bad-whitespace: Exactly one space required after comma         python_versions = ["3.6","3.7","3.8"]                                       ^
test/lib/ansible_test/_internal/executor.py:1460:25: bad-whitespace: No space allowed after bracket         callback_paths = [ "/usr/lib/python%s/site-packages/ara/plugins/callback" % version for version in python_versions ]                          ^
test/lib/ansible_test/_internal/executor.py:1460:123: bad-whitespace: No space allowed before bracket         callback_paths = [ "/usr/lib/python%s/site-packages/ara/plugins/callback" % version for version in python_versions ]                                                                                                                            ^

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

test/lib/ansible_test/_internal/executor.py:1459:33: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1459:39: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1460:27: E201: whitespace after '['
test/lib/ansible_test/_internal/executor.py:1460:123: E202: whitespace before ']'

The test ansible-test sanity --test test-constraints [explain] failed with 2 errors:

test/lib/ansible_test/_data/requirements/integration.txt:7:4: put constraints in `test/lib/ansible_test/_data/requirements/constraints.txt`
test/lib/ansible_test/_data/requirements/network-integration.txt:8:4: put constraints in `test/lib/ansible_test/_data/requirements/constraints.txt`

click here for bot help

@ansibot
Copy link
Contributor

@ansibot ansibot commented Jan 17, 2021

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

test/lib/ansible_test/_internal/executor.py:1498:29: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1498:35: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1498:41: E231: missing whitespace after ','
test/lib/ansible_test/_internal/executor.py:1499:23: E201: whitespace after '['
test/lib/ansible_test/_internal/executor.py:1499:119: E202: whitespace before ']'

The test ansible-test sanity --test pylint [explain] failed with 5 errors:

test/lib/ansible_test/_internal/executor.py:1498:28: bad-whitespace: Exactly one space required after comma     python_versions = ["3.6","3.7","3.8","3.9"]                             ^
test/lib/ansible_test/_internal/executor.py:1498:34: bad-whitespace: Exactly one space required after comma     python_versions = ["3.6","3.7","3.8","3.9"]                                   ^
test/lib/ansible_test/_internal/executor.py:1498:40: bad-whitespace: Exactly one space required after comma     python_versions = ["3.6","3.7","3.8","3.9"]                                         ^
test/lib/ansible_test/_internal/executor.py:1499:21: bad-whitespace: No space allowed after bracket     callback_paths = [ "/usr/lib/python%s/site-packages/ara/plugins/callback" % version for version in python_versions ]                      ^
test/lib/ansible_test/_internal/executor.py:1499:119: bad-whitespace: No space allowed before bracket     callback_paths = [ "/usr/lib/python%s/site-packages/ara/plugins/callback" % version for version in python_versions ]                                                                                                                        ^

click here for bot help

@mattclay
Copy link
Member

@mattclay mattclay commented Sep 23, 2021

@dmsimard Is this still needed, or can it be closed?

@dmsimard
Copy link
Contributor Author

@dmsimard dmsimard commented Sep 24, 2021

Hey @mattclay o/

There is no need to keep this opened so I'll close it for now but I would be interested in discussing the right (non-hacky/PoC) approach to do what this PR does sometime in the future.

@dmsimard dmsimard closed this Sep 24, 2021
@ansible ansible locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants