Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OpenBSD syspatch module bug #57259

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@precurse
Copy link
Contributor

commented Jun 1, 2019

SUMMARY

Fixes bug with OpenBSD syspatch module. Meant to push it to my branch before was pulled in today: #55561

Also adds a new playbook example. Renames a variable to be more consistent with other Ansible modules.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

syspatch

ADDITIONAL INFORMATION

This fixes a logic issue and issue where append was being used incorrectly.

FAILED! => {"changed": false, "module_stderr": "Shared connection to 127.0.0.1 closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n  File \"/root/.ansible/tmp/ansible-tmp-1559353159.453823-221920894433339/AnsiballZ_syspatch.py\", line 114, in <module>\r\n    _ansiballz_main()\r\n  File \"/root/.ansible/tmp/ansible-tmp-1559353159.453823-221920894433339/AnsiballZ_syspatch.py\", line 106, in _ansiballz_main\r\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\r\n  File \"/root/.ansible/tmp/ansible-tmp-1559353159.453823-221920894433339/AnsiballZ_syspatch.py\", line 49, in invoke_module\r\n    imp.load_module('__main__', mod, module, MOD_DESC)\r\n  File \"/usr/local/lib/python3.6/imp.py\", line 235, in load_module\r\n    return load_source(name, filename, file)\r\n  File \"/usr/local/lib/python3.6/imp.py\", line 170, in load_source\r\n    module = _exec(spec, sys.modules[name])\r\n  File \"<frozen importlib._bootstrap>\", line 618, in _exec\r\n  File \"<frozen importlib._bootstrap_external>\", line 678, in exec_module\r\n  File \"<frozen importlib._bootstrap>\", line 219, in _call_with_frames_removed\r\n  File \"/tmp/ansible_syspatch_payload_i0tv3135/__main__.py\", line 175, in <module>\r\n  File \"/tmp/ansible_syspatch_payload_i0tv3135/__main__.py\", line 171, in main\r\n  File \"/tmp/ansible_syspatch_payload_i0tv3135/__main__.py\", line 95, in run_module\r\n  File \"/tmp/ansible_syspatch_payload_i0tv3135/__main__.py\", line 149, in syspatch_run\r\nTypeError: 'builtin_function_or_method' object is not subscriptable\r\n", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

Sorry about that @bcoca !

@ansibot ansibot removed the small_patch label Jun 1, 2019

@jasperla

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

Makes sense to me to me

@ansibot ansibot added the stale_ci label Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.