Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_acl: Fix problems with special IDRef in different languages than english #57281

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@ShachafGoldstein
Copy link
Contributor

commented Jun 2, 2019

SUMMARY

Fixes #56757

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_acl.ps1

ADDITIONAL INFORMATION

@ShachafGoldstein ShachafGoldstein changed the title 56757 win_acl: Fix problems with special IDRef in different languages than english Jun 2, 2019

@ansibot

This comment has been minimized.

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

@jborean93 @jhawkesworth @nitzmahone - Please review when you have the time

$idRefShortValue = ($rule.IdentityReference.Value).split('\')[-1]

if ( $idRefShortValue -in $specialIdRefs ) {
if ( $idRefShortPrefix -in $specialIdRefPrefixes ) {

This comment has been minimized.

Copy link
@jhawkesworth

jhawkesworth Jun 25, 2019

Contributor

This is probably a really tiny nitpick, but would
if ( $idRefShortPrefix -eq $specialIdRefPrefixes ) {
be clearer here, since $specialIdRefPrefixes is just a string not an Array?
I think -in and -eq behave the same in this case but I think -eq would make it clearer what the intention is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.