Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_syslog - Module properly handles net_id parameter #57286

Merged
merged 1 commit into from Jun 12, 2019
Merged

meraki_syslog - Module properly handles net_id parameter #57286

merged 1 commit into from Jun 12, 2019

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Jun 3, 2019

SUMMARY

Module has net_id as an option but passing net_idwould be ignored. The module now handles net_id and doesn't do lookups if it's passed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki_syslog

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jun 3, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 3, 2019
@kbreit kbreit mentioned this pull request Jun 6, 2019
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 11, 2019
@Qalthos Qalthos merged commit a50b3d7 into ansible:devel Jun 12, 2019
@kbreit kbreit deleted the meraki/syslog_remove_calls branch June 12, 2019 14:53
agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019
@kbreit @agowa
meraki_syslog - Module properly handles net_id parameter (ansible#57286)
474529e
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbreit @bcoca @Qalthos @ansibot