Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module - meraki_firewalled_services #57289

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@kbreit
Copy link
Contributor

commented Jun 3, 2019

SUMMARY
  • Module can query or modify network services on Meraki gear
  • Check mode supported
  • Integration tests included

Fixes #48613

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

meraki_firewalled_services

ADDITIONAL INFORMATION
    data:
    - access: blocked
      service: ICMP
    - access: restricted
      allowedIps:
      - 192.0.1.1
      - 192.0.1.2
      service: web

kbreit added some commits Jun 3, 2019

Initial commit for module
- Module can query or modify network services on Meraki gear
- Check mode supported
- Integration tests included

@ansibot ansibot added stale_ci and removed needs_triage labels Jun 12, 2019

@Qalthos
Copy link
Contributor

left a comment

I agree with Ganesh's note, otherwise it looks fine.

@kbreit

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

@ganeshrn or @Qalthos - Can you please review and merge if happy?

@ansibot ansibot removed the stale_ci label Jun 18, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/meraki/meraki_firewalled_services.py:161:37: bad-whitespace Exactly one space required after comma     mutually_exclusive = [('net_name',  'net_id')]                                      ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/meraki/meraki_firewalled_services.py:161:39: E241 multiple spaces after ','

click here for bot help

@Qalthos

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

shipit

@ansibot ansibot added shipit and removed community_review labels Jun 18, 2019

@ansibot ansibot added community_review and removed shipit labels Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.