Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stack policy on update #57300

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@fvant
Copy link
Contributor

commented Jun 3, 2019

SUMMARY

Cloudformation supports a policy that applies to a particular update only.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/cloudformation.py

ADDITIONAL INFORMATION

Use the aws cloudformation update-stack command with the --stack-policy-during-update-body option to type in a modified policy..

AWS CloudFormation applies the override policy only during this update. The override policy doesn't permanently change the stack policy. To modify a stack policy, see Modifying a Stack Policy .
Boto3 documentation of the parameter used:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation.html#CloudFormation.Client.update_stack


@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/cloudformation.py:776:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/cloudformation.py:776:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/cloudformation.py:0:0: E308 version_added for new option (stack_policy_on_update) is not a valid version number: '2.x'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@fvant, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/cloudformation.py:0:0: E309 version_added for new option (stack_policy_on_update) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@samdoran samdoran removed the needs_triage label Jun 4, 2019

@samdoran

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Please add integration tests for this new feature.

@ansibot ansibot added the stale_ci label Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.