Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding waiter to cluster remove process #57324

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@inhumantsar
Copy link

commented Jun 3, 2019

SUMMARY

This PR adds a waiter to the AWS EKS cluster remove process.

This should make life easier when automating the removal of dependent resources such as Security Groups and Subnets.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_eks_cluster

ADDITIONAL INFORMATION

I'm a new contributor, please be nice :)

@inhumantsar inhumantsar changed the title WIP: Adding waiter to cluster remove process Adding waiter to cluster remove process Jun 3, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@inhumantsar, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@willthames

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

This looks great - can you update the test suite (test/integration/targets/aws_eks) to use this?

@ansibot ansibot removed the needs_triage label Jun 3, 2019

@inhumantsar

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

@willthames thanks :) added

@willthames
Copy link
Contributor

left a comment

This needs version checks - looks like cluster_deleted needs 1.12.38

@willthames

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@inhumantsar I've updated the test suite to latest ansible test suite standards

You'll need to add a test to old_version.yml for using wait with state absent for versions older than 1.12.38 and some logic to aws_eks_cluster to ensure that that test passes

@inhumantsar

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

@willthames would it be reasonable to have Ansible warn and ignore wait=yes rather than fail outright?

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

@inhumantsar this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

@inhumantsar This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.
  • More than 50 commits.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added the merge_commit label Jun 7, 2019

@inhumantsar

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

i hate git sometimes

@ansible-zuul

This comment has been minimized.

@willthames willthames force-pushed the inhumantsar:feature/eks_remove_wait branch from 6d72536 to 0eeba28 Jun 10, 2019

@willthames

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@inhumantsar I've fixed up your branch. It's best to ensure you do git pull --rebase rather than just git pull.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:0: syntax-error invalid syntax (<unknown>, line 282)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 813, in <module>
    main()
  File "../bin/plugin_formatter.py", line 768, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 298, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 282
    if (not module.botocore_at_least("1.12.38")) and
                                                   ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: if (not module.botocore_at_least("1.12.38")) and

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: if (not module.botocore_at_least("1.12.38")) and

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: if (not module.botocore_at_least("1.12.38")) and

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: if (not module.botocore_at_least("1.12.38")) and

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: if (not module.botocore_at_least("1.12.38")) and

The test ansible-test sanity --test compile --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: if (not module.botocore_at_least("1.12.38")) and

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:283:13: E113 unexpected indentation
lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:285:9: E901 IndentationError: unindent does not match any outer indentation level

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_eks_cluster.py:282:53: python-syntax-error invalid syntax (<unknown>, line 282)

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.