Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sparse volumes #57354

Open
wants to merge 3 commits into
base: devel
from
Open
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -58,6 +58,14 @@
extra_zfs_properties:
volsize: 10M
- name: Create a new sparse volume called myvol in pool rpool.
zfs:
name: rpool/myvol
state: present
extra_zfs_properties:
volsize: 10M
sparse: true
- name: Create a snapshot of rpool/myfs file system.
zfs:
name: rpool/myfs@mysnapshot
@@ -158,6 +166,9 @@ def create(self):
cmd += ['-V', value]
elif prop == 'volblocksize':
cmd += ['-b', value]
elif prop == 'sparse':
if value == 'on':
This conversation was marked as resolved by Area128

This comment has been minimized.

Copy link
@mator

mator Jun 4, 2019

Contributor

probably better to use:

if check_type_bool(value):

or just ignore (resolve) this review/comment. Thanks.

This comment has been minimized.

Copy link
@Area128

Area128 Jun 20, 2019

Author

Thanks, done.

cmd += ['-s']
else:
cmd += ['-o', '%s="%s"' % (prop, value)]
if origin and action == 'clone':
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.