Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: Add affinity parameters #57359

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
4 participants
@machacekondra
Copy link
Contributor

commented Jun 4, 2019

SUMMARY

This PR add three new parameter to kubevirt modules, node_affinity, affinity and anti_affinity

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

kubevirt

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/kubevirt/kubevirt_vm.py:198:13: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/kubevirt/kubevirt_vm.py:198:13: error EXAMPLES: syntax error: could not find expected ':'

click here for bot help

@machacekondra machacekondra force-pushed the machacekondra:kubevirt_affinity branch from aca6f61 to 8e9e450 Jun 5, 2019

@ansibot ansibot removed the needs_triage label Jun 5, 2019

@machacekondra machacekondra force-pushed the machacekondra:kubevirt_affinity branch from 8e9e450 to 7d8b0b1 Jun 6, 2019

@mmazur

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

+1

@ansibot ansibot added shipit and removed community_review labels Jun 13, 2019

@mkrizek
Copy link
Contributor

left a comment

See my comment about version_added.

@ansibot ansibot added needs_revision and removed shipit labels Jun 13, 2019

@machacekondra machacekondra force-pushed the machacekondra:kubevirt_affinity branch from 7d8b0b1 to 183ef3e Jun 13, 2019

@mkrizek mkrizek merged commit 886f4c6 into ansible:devel Jun 13, 2019

1 check passed

Shippable Run 127436 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.