Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled check mode on nxos bgp modules #57360

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@jacobsnapp
Copy link

commented Jun 4, 2019

SUMMARY

Implemented "Check Mode" for the following NXOS BGP modules:

  • nxos_bgp
  • nxos_bgp_af
  • nxos_bgp_neighbor
  • nxos_bgp_neighbor_af
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • nxos_bgp
  • nxos_bgp_af
  • nxos_bgp_neighbor
  • nxos_bgp_neighbor_af
ADDITIONAL INFORMATION

I unfortunately found out that these modules did not have "check mode" implemented when testing against network infrastructure and thought I would contribute back to the community.


@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@jacobsnapp, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

jacobsnapp added some commits Jun 4, 2019

@chrisvanheuveln

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

shipit

@doubleshot

This comment has been minimized.

Copy link

commented Jun 6, 2019

Dangerous bug, should look to backporting as well.

@mikewiebe

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

LGTM

@ansibot ansibot added shipit and removed core_review labels Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.