Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTD was not idempotent #57372

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@carchi8py
Copy link
Contributor

commented Jun 4, 2019

SUMMARY

MOTD was not idempotent

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_motd.py
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot ansibot removed the needs_triage label Jun 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:3529:1: A102 Remove since "lib/ansible/modules/storage/netapp/na_ontap_motd.py" passes "E337" test

click here for bot help

carchi8py added some commits Jun 3, 2019

@carchi8py carchi8py force-pushed the carchi8py:1583 branch from d192bf0 to 866c192 Jun 17, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@ansibot ansibot added support:core and removed ci_verified labels Jun 17, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/storage/netapp/na_ontap_motd.py:0:0: E338 Argument 'state' in argument_spec uses default type ('str') but documentation doesn't define type
test/sanity/validate-modules/ignore.txt:3528:1: A102 Remove since "lib/ansible/modules/storage/netapp/na_ontap_motd.py" passes "E337" test

click here for bot help

@ansibot ansibot added the ci_verified label Jun 17, 2019

@lonico

lonico approved these changes Jun 18, 2019

Copy link
Contributor

left a comment

shipit

@lonico

lonico approved these changes Jun 19, 2019

Copy link
Contributor

left a comment

shipit

@ansibot ansibot added shipit and removed core_review labels Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.