Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign a sane default to yum/dnf lock_timeout, in line with cli #57383

Conversation

Projects
None yet
5 participants
@maxamillion
Copy link
Contributor

commented Jun 5, 2019

Fixes #57189

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

In Ansible 2.8.0, we appropriately handle the yum and dnf lockfiles instead of ignoring them. However, the default selected originally is not very practical and this change brings the default value in alignment with the cli tools (and, as a side effect, the old behavior).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum
dnf

assign a sane default to yum/dnf lock_timeout, in line with cli
Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test changelog [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/changelog.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 833, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 101, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 112, in command_lint
    lint_fragments(fragments, exceptions)
  File "packaging/release/changelogs/changelog.py", line 234, in lint_fragments
    errors += linter.lint(fragment)
  File "packaging/release/changelogs/changelog.py", line 307, in lint
    for section, lines in fragment.content.items():
AttributeError: 'list' object has no attribute 'items'
Traceback (most recent call last):
  File "test/sanity/code-smell/changelog.py", line 24, in <module>
    main()
  File "test/sanity/code-smell/changelog.py", line 20, in main
    subprocess.check_call(cmd)
  File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['packaging/release/changelogs/changelog.py', 'lint', 'changelogs/fragments/yum-sane-default-lockfile-timeout.yml']' returned non-zero exit status 1.

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Jun 5, 2019

@@ -0,0 +1,3 @@
- minor_changes:

This comment has been minimized.

Copy link
@mkrizek

mkrizek Jun 5, 2019

Contributor
Suggested change
- minor_changes:
minor_changes:

@ansibot ansibot removed the needs_triage label Jun 5, 2019

@mkrizek

mkrizek approved these changes Jun 5, 2019

Copy link
Contributor

left a comment

LGTM, except the typo in the changelog (I tried to commit the suggestion but didn't have permissions to do so).

@kustodian

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

shipit

@thaumos

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Can we get a porting guide entry in 2.8 backported for this as an FYI to folks?

fix typo in changelog snippet
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@thaumos after this PR is backported, I'm not certain we need a porting guide entry because the functionality will be identical to what it used to be

@ansibot ansibot added core_review and removed needs_revision labels Jun 13, 2019

@thaumos

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

kk, that's fine with me!

@maxamillion

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

rebuild_merge

@ansibot ansibot added shipit and removed core_review labels Jun 13, 2019

@ansibot ansibot merged commit d2dc4c9 into ansible:devel Jun 13, 2019

1 check passed

Shippable Run 127482 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.