Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared image gallery modules #57386

Open
wants to merge 19 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@zikalino
Copy link
Contributor

commented Jun 5, 2019

SUMMARY

This is to implement shared image gallery

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_gallery
azure_rm_galleryimage
azure_rm_galleryimageversion

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@zikalino this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test import --python 2.6 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ImportError: No module named msrestazure.azure_exceptions
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ImportError: No module named msrestazure.azure_exceptions
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ImportError: No module named msrestazure.azure_exceptions

The test ansible-test sanity --test import --python 2.7 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ImportError: No module named msrestazure.azure_exceptions
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ImportError: No module named msrestazure.azure_exceptions
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ImportError: No module named msrestazure.azure_exceptions

The test ansible-test sanity --test import --python 3.5 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ImportError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ImportError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ImportError: No module named 'msrestazure'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ModuleNotFoundError: No module named 'msrestazure'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ModuleNotFoundError: No module named 'msrestazure'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ModuleNotFoundError: No module named 'msrestazure'

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:261:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_gallery.py:262:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_gallery.py:263:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:471:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:472:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:473:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:367:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:368:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:369:12: E111 indentation is not a multiple of four

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E323 Argument 'gallery_image' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E326 Argument 'os_state' in argument_spec defines choices as (['Generalized', 'Specialized']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E326 Argument 'os_type' in argument_spec defines choices as (['Windows', 'Linux']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: E323 Argument 'gallery_image_version' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/azure_rm_gallery/tasks/main.yml:100:1: empty-lines too many blank lines (1 > 0)

click here for bot help

zikalino added some commits Jun 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

cc @needgithubid
click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test import --python 2.6 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ImportError: No module named msrestazure.azure_exceptions
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ImportError: No module named msrestazure.azure_exceptions
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ImportError: No module named msrestazure.azure_exceptions

The test ansible-test sanity --test import --python 2.7 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ImportError: No module named msrestazure.azure_exceptions
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ImportError: No module named msrestazure.azure_exceptions
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ImportError: No module named msrestazure.azure_exceptions

The test ansible-test sanity --test import --python 3.5 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ImportError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ImportError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ImportError: No module named 'msrestazure'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ModuleNotFoundError: No module named 'msrestazure'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ModuleNotFoundError: No module named 'msrestazure'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 3 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:110:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:211:0: ModuleNotFoundError: No module named 'msrestazure'
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:173:0: ModuleNotFoundError: No module named 'msrestazure'

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:261:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_gallery.py:262:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_gallery.py:263:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:471:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:472:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:473:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:367:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:368:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:369:12: E111 indentation is not a multiple of four

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E323 Argument 'gallery_image' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E326 Argument 'os_state' in argument_spec defines choices as (['Generalized', 'Specialized']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E326 Argument 'os_type' in argument_spec defines choices as (['Windows', 'Linux']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: E323 Argument 'gallery_image_version' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:0: syntax-error unexpected indent (<unknown>, line 254)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 813, in <module>
    main()
  File "../bin/plugin_formatter.py", line 768, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 298, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 254
    state=dict(
    ^
IndentationError: unexpected indent
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: SyntaxError: state=dict(

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: SyntaxError: state=dict(

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: SyntaxError: state=dict(

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: SyntaxError: state=dict(

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: SyntaxError: state=dict(

The test ansible-test sanity --test compile --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: SyntaxError: state=dict(

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: IndentationError: unexpected indent

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: IndentationError: unexpected indent

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: IndentationError: unexpected indent

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: IndentationError: unexpected indent

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: IndentationError: unexpected indent

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: IndentationError: unexpected indent

The test ansible-test sanity --test pep8 [explain] failed with 85 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:265:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_gallery.py:266:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_gallery.py:267:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:475:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:476:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:477:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:233:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:234:21: E131 continuation line unaligned for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:237:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:238:21: E131 continuation line unaligned for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:241:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:242:21: E131 continuation line unaligned for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:245:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:246:21: E131 continuation line unaligned for hanging indent
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:251:21: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:252:17: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:253:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:13: E113 unexpected indentation
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:18: E225 missing whitespace around operator
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:261:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:261:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:261:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:262:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:262:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:262:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:263:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:263:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:263:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:264:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:264:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:264:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:265:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:265:35: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:265:37: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:267:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:267:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:267:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:267:36: E225 missing whitespace around operator
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:268:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:268:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:268:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:269:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:269:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:269:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:270:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:270:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:270:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:271:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:271:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:271:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:272:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:272:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:272:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:274:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:274:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:274:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:275:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:275:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:275:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:276:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:276:45: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:276:47: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:277:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:277:31: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:277:33: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:278:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:278:47: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:278:49: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:280:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:280:75: E225 missing whitespace around operator
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:281:59: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:281:59: E113 unexpected indentation
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:281:78: E225 missing whitespace around operator
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:282:59: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:282:72: E225 missing whitespace around operator
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:284:5: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:289:31: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:289:33: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:293:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:293:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:294:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:294:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:296:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:296:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:297:53: E901 IndentationError: unindent does not match any outer indentation level

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E323 Argument 'gallery_image' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E326 Argument 'os_state' in argument_spec defines choices as (['Generalized', 'Specialized']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:0:0: E326 Argument 'os_type' in argument_spec defines choices as (['Windows', 'Linux']) but documentation defines choices as ([])
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:254:12: python-syntax-error unexpected indent (<unknown>, line 254)

click here for bot help

zikalino added some commits Jun 5, 2019

fix
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/modules/cloud/azure/azure_rm_gallery.py:265:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_gallery.py:266:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_gallery.py:267:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:476:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:477:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimage.py:478:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:368:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:369:12: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:370:12: E111 indentation is not a multiple of four

click here for bot help

zikalino added some commits Jun 5, 2019

zikalino added some commits Jun 5, 2019

@zikalino zikalino closed this Jun 5, 2019

@zikalino zikalino reopened this Jun 5, 2019

zikalino added some commits Jun 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_galleryimageversion.py:227:35: E127 continuation line over-indented for visual indent

click here for bot help

@ansibot ansibot added the ci_verified label Jun 5, 2019

@ansibot ansibot removed the ci_verified label Jun 5, 2019

@zikalino zikalino changed the title [WIP] shared image gallery modules shared image gallery modules Jun 5, 2019

@ansibot ansibot added needs_revision and removed WIP labels Jun 5, 2019

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@yungezz @yuwzho Please help to review this PR when you're available! Thanks a lot!

@zikalino zikalino requested a review from nitzmahone Jun 11, 2019

---
module: azure_rm_gallery
version_added: '2.9'
short_description: Manage Azure Gallery instance.

This comment has been minimized.

Copy link
@yungezz

yungezz Jun 11, 2019

Contributor

image gallery or gallery?

required: true
name:
description:
- >-

This comment has been minimized.

Copy link
@yungezz

yungezz Jun 11, 2019

Contributor

?

This comment has been minimized.

Copy link
@nitzmahone

nitzmahone Jun 13, 2019

Member

>- is a YAML folded string with block chomping enabled (see https://yaml.org/spec/1.1/#id927557)

location:
description:
- Resource location
required: true

This comment has been minimized.

Copy link
@yungezz

yungezz Jun 11, 2019

Contributor

is this always required even when updating?

required: true
description:
description:
- >-

This comment has been minimized.

Copy link
@yungezz

yungezz Jun 11, 2019

Contributor

why just single line?

description:
- Assert the state of the Gallery.
- >-
Use C(present) to create or update an Gallery and C(absent) to delete

This comment has been minimized.

Copy link
@yungezz

yungezz Jun 11, 2019

Contributor

why not just single line?

- name: Create or update a simple gallery.
azure_rm_gallery:
resource_group: myResourceGroup
name: myGallery1283

This comment has been minimized.

Copy link
@yungezz

yungezz Jun 11, 2019

Contributor

myGallery?

old_response = None
response = None

self.mgmt_client = self.get_mgmt_svc_client(GenericRestClient,

This comment has been minimized.

Copy link
@yungezz

yungezz Jun 11, 2019

Contributor

why using rest client? there's no management client?

@ansibot ansibot removed the needs_triage label Jun 11, 2019

@nitzmahone
Copy link
Member

left a comment

A few little things, but otherwise LGTM. I was initially thinking it should be azure_rm_sharedimagegallery_X, since there are other things named "gallery", but after some thought I think the names already there are fine...

required: true
name:
description:
- >-

This comment has been minimized.

Copy link
@nitzmahone

nitzmahone Jun 13, 2019

Member

>- is a YAML folded string with block chomping enabled (see https://yaml.org/spec/1.1/#id927557)

description:
- >-
The name of the Shared Image Gallery. The allowed characters are
alphabets and numbers with dots and periods allowed in the middle. The

This comment has been minimized.

Copy link
@nitzmahone

nitzmahone Jun 13, 2019

Member

Maybe something like "Valid names consist of less than 80 alphanumeric characters, underscores and periods."?

end_of_life_date:
description:
- >-
The end of life date of the gallery Image Definition. This property can

This comment has been minimized.

Copy link
@nitzmahone

nitzmahone Jun 13, 2019

Member

example of the required format?

the Image Definition won't use this Image Version.
end_of_life_date:
description:
- >-

This comment has been minimized.

Copy link
@nitzmahone

nitzmahone Jun 13, 2019

Member

sample format?

# do not test delete at the moment as it will fail due to mysterious nested resource
# deleting resource group will delete all the resources

#- name: Delete gallery Image Version.

This comment has been minimized.

Copy link
@nitzmahone

nitzmahone Jun 13, 2019

Member

Does deletion work without replication? I'm wondering if it's preventing deletion because the replication is in progress...

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

@zikalino Please help finish the PR change when you're free! Thank you very much!

@ansibot ansibot added the stale_ci label Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.