Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tower_workflow_template: unify implementation and add missing parameters #57401

Open
wants to merge 9 commits into
base: devel
from

Conversation

Projects
None yet
6 participants
@keilr
Copy link

commented Jun 5, 2019

SUMMARY

The implementation of the modules tower_workflow_template and tower_job_template diverge in terms of parameter naming and code structure.

Parameters:

tower_job_template tower_workflow_template
ask_inventory missing
inventory missing
ask_extra_vars missing
concurrent_jobs_enabled allow_simultaneous
survey_spec survey

This PR tries to unify those two modules, to improve usability and maintainability.

Fixes #57350

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

tower_workflow_template

ADDITIONAL INFORMATION

I took into account latest PR (#57225) which affects the tower_job_template module.

PR "tower_workflow_template: Add missing options" #56891 would be obsolete.

@keilr

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

@dlerch-tpgroup please take a look

I adopted your latest changes as well.

@keilr

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

fixes #57350

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/web_infrastructure/ansible_tower/tower_workflow_template.py:0:0: E309 version_added for new option (ask_extra_vars) should be '2.9'. Currently StrictVersion ('0.0')
lib/ansible/modules/web_infrastructure/ansible_tower/tower_workflow_template.py:0:0: E309 version_added for new option (concurrent_jobs_enabled) should be '2.9'. Currently StrictVersion ('2.7')
lib/ansible/modules/web_infrastructure/ansible_tower/tower_workflow_template.py:0:0: E322 Argument 'allow_simultaneous' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/web_infrastructure/ansible_tower/tower_workflow_template.py:0:0: E322 Argument 'survey' is listed in the argument_spec, but not documented in the module documentation

click here for bot help

@dlerch-tpgroup

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@dlerch-tpgroup please take a look

I adopted your latest changes as well.

looks good to me, thanks for the implementation

@ansibot ansibot added core_review and removed needs_revision labels Jun 5, 2019

@albertomurillo

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

lgtm!
Just add ask_extra_vars to changelog and porting documentation

@ansibot ansibot added needs_revision and removed core_review labels Jun 5, 2019

@ansibot ansibot added the needs_rebase label Jun 6, 2019

@bcoca bcoca removed the needs_triage label Jun 6, 2019

@keilr keilr force-pushed the keilr:devel branch from 98c58cc to 4410b6d Jun 6, 2019

@ansibot ansibot removed the needs_rebase label Jun 6, 2019

@keilr

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

CI tests fail due to old Ansible Tower version in testing environment. Can someone update to 3.4.3 or 3.5.0?

See #57490

Related Ansible Tower 3.4.0 Release Notes:

Added optional and promptable inventory field to Workflow job templates (WFJTs)- the selected inventory will override the inventory of any Job Template node that prompts for an inventory, which includes inventory prompt-on-launch for standalone WFJTs, nested WFJT nodes, and WFJT schedules

@AlanCoding

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

CI tests fail due to old Ansible Tower version in testing environment. Can someone update to 3.4.3 or 3.5.0?

@chrismeyersfsu is working on revamping these, but it will still take some time. Sorry for the delay.

@albertomurillo

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

@keilr you need to rebase this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.