Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vlan update on ovs bridges (#57168) #57413

Merged
merged 1 commit into from Jun 19, 2019

Conversation

Projects
None yet
4 participants
@danielmellado
Copy link
Contributor

commented Jun 5, 2019

SUMMARY

Backport from devel

Add support for vlan update on ovs bridges

This commit adds support for updating vlan to an existing openvswitch bridge,
which was previously ignored-

Fixes #57018

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openvswitch_brige

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@danielmellado, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

We've enabled zuul jobs for ovs, on stable-2.8, but they are not reporting to github.com currently. The next comment will kick off the builds, and I'll follow up by posting the results manually. Once confirmed these jobs are still green, we can discuss enabling the publishing of the results directly.

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

recheck

@ansibot ansibot removed the needs_triage label Jun 5, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

This passed as expected:
https://dashboard.zuul.ansible.com/t/ansible/build/a570883502a546aa8dd41192bc68551a

@abadger are you okay with us enabling results to be posted back for stable-2.8 on openvswitch related changes?

@danielmellado

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Pull-request updated, HEAD is now 50d574f

@danielmellado danielmellado force-pushed the danielmellado:stable-2.8 branch from 6d31b11 to 50d574f Jun 10, 2019

@danielmellado

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Pull-request updated, HEAD is now 98e57b3

@danielmellado danielmellado force-pushed the danielmellado:stable-2.8 branch from 50d574f to 98e57b3 Jun 10, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

This change needs a changelog fragment in order to be merged to the stable-2.8 branch. Looks good after that is added.

@abadger

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

@pabelanger and yes, if tests are green, then I'm fine with the results being posted to github.

Add support for vlan update on ovs bridges (#57168)
This commit adds support for vlan update on openvswitch_bridge module.

(cherry picked from commit 091bebc)
@danielmellado

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

Pull-request updated, HEAD is now 75db850

@danielmellado danielmellado force-pushed the danielmellado:stable-2.8 branch from 98e57b3 to 75db850 Jun 19, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 19, 2019

@abadger abadger merged commit 20fa115 into ansible:stable-2.8 Jun 19, 2019

2 checks passed

Shippable Run 128385 status is SUCCESS.
Details
ansible/third-party-check third-party-check status: success
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

Merged for the 2.8.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.