Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description of 'hostname' #57421

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@natereid72
Copy link

commented Jun 5, 2019

SUMMARY

The documentation refers to esxi hostname for both 'hostname' and 'esxi_hostname'. I found that hostname is intended for vCenter host definition and is required when working with vds. I did not update examples, only the description section.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Added description for 'hostname' to readme.

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vmkernel.py:0:0: E305 DOCUMENTATION.options.hostname.descriptiom: extra keys not allowed @ data['options']['hostname']['descriptiom']. Got ['Address or fqdn of the vCenter if present, required if using distributed virtual switch']

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@natereid72, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@acozine

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

@natereid72 thank you for your interest in refining the Ansible documentation! The hostname parameter is documented in the shared documentation for all vmware modules.

On the published docs for this module, the two parameters show up side by side:

Screen Shot 2019-06-18 at 2 31 38 PM

The change in the current PR is not correct, but feel free to open a new PR to update the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.