Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] meraki - is_update_required type comparison fix #57440

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@kbreit
Copy link
Contributor

commented Jun 6, 2019

SUMMARY

The new is_update_required() pull request introduced a bug which wasn't always reproducible. The type comparison would fail when comparing unicast and strings. sivel recommended using the string_types and make sure they aren't string_types. I've run many integration test and this seems to fix the problem.

This pull request also includes a few other fixes I've uncovered while testing.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki

kbreit added some commits Jun 5, 2019

Improve type check in is_update_required()
- Certain conditions seem to cause the check to fail for comparing unicode and str
- Comparing both objects to string_types seems to fix it but needs more testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.