Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotence all grant #57460

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@azeliashchonak
Copy link

commented Jun 6, 2019

SUMMARY

In MySQL 8.0 SHOW GRANTS no longer displays ALL PRIVILEGES in its global-privileges output. Instead, SHOW GRANTS explicitly lists each granted global privilege. The issue is that the mysql_user module is using a simple comparison between new and current privileges and if we define ".:ALL,GRANT" it will return changed, because "ALL" != list_of_privileges, so idempotence check will be failed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

mysql_user

ADDITIONAL INFORMATION

Instead of #55140


@ansibot

This comment has been minimized.

@azeliashchonak

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

/ready_for_review

@tgadiev

This comment has been minimized.

Copy link

commented Jun 10, 2019

@bmalynovytch can you take a look, please?

@ansibot ansibot added the stale_ci label Jun 18, 2019

return privileges


def get_db_version(cursor):

This comment has been minimized.

Copy link
@bmalynovytch

bmalynovytch Jun 20, 2019

Contributor

I think it would be best to refactor use_old_user_mgmt to handle all versions manipulation (ie returning a clear string stating which kind of user management we should use, for example PASSWORD_ONLY or LEGACY, PASSWORD_OR_AUTH_STRING, MYSQL_8_PLUS ...)

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

@ansibot ansibot removed the needs_triage label Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.