Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins_build module #57468

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@brettmilford
Copy link
Contributor

commented Jun 6, 2019

SUMMARY

This module is primarily queuing and polling jenkins builds.
The module aims to follow similar design/pattern of the jenkins_job module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

jenkins_build

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:179:68: bad-whitespace Exactly one space required after comma         self.module.fail_json(msg='state=absent not implimented yet',exception=traceback.format_exc())                                                                     ^

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/web_infrastructure/jenkins_build.py:12:1: E124 closing bracket does not match visual indentation
lib/ansible/modules/web_infrastructure/jenkins_build.py:111:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/web_infrastructure/jenkins_build.py:179:69: E231 missing whitespace after ','
lib/ansible/modules/web_infrastructure/jenkins_build.py:194:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: E305 DOCUMENTATION.options.url.description.0: expected str @ data['options']['url']['description'][0]. Got {'URL where the Jenkins server is accessible. required': False}

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:183:0: syntax-error invalid syntax (<unknown>, line 183)

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 813, in <module>
    main()
  File "../bin/plugin_formatter.py", line 768, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 298, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 183
    exception=traceback.format_exc()))
                                     ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:183:68: SyntaxError: exception=traceback.format_exc()))

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:183:68: SyntaxError: exception=traceback.format_exc()))

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:183:68: SyntaxError: exception=traceback.format_exc()))

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:183:68: SyntaxError: exception=traceback.format_exc()))

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:183:68: SyntaxError: exception=traceback.format_exc()))

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jenkins_build.py:196:0: SyntaxWarning: "is not" with a literal. Did you mean "!="?

click here for bot help

@brettmilford brettmilford force-pushed the brettmilford:jenkins_build branch from b961b50 to 07d9609 Jun 14, 2019

@ansibot ansibot removed the ci_verified label Jun 14, 2019

Created jenkins_build module
Primarily for queueing and deleting jenkins builds.
Is designed to be similar in style and syntax to jenkins_job.

@brettmilford brettmilford force-pushed the brettmilford:jenkins_build branch from 07d9609 to 850c084 Jun 14, 2019

@brettmilford brettmilford changed the title preview jenkins_build module jenkins_build module Jun 14, 2019

@brettmilford

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

broke the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.