Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeIPA: Add new modules - ipa_permission and ipa_privilege #57479

Open
wants to merge 18 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@HaloGithub
Copy link

commented Jun 6, 2019

SUMMARY

Currently there is ipa_role module can create or update FreeIPA role, but there is no module to create or update FreeIPA privilege and permission so that can make Role-Based Access Control complete. That's why I implement these two modules.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • ipa_permission
  • ipa_privilege
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/identity/ipa/ipa_permission.py:208:24: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/identity/ipa/ipa_privilege.py:103:32: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/identity/ipa/ipa_privilege.py:169:24: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/identity/ipa/ipa_permission.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/identity/ipa/ipa_permission.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'Lek'
lib/ansible/modules/identity/ipa/ipa_permission.py:0:0: E307 version_added should be '2.9'. Currently '2.8'
lib/ansible/modules/identity/ipa/ipa_privilege.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/identity/ipa/ipa_privilege.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'Lek'
lib/ansible/modules/identity/ipa/ipa_privilege.py:0:0: E307 version_added should be '2.9'. Currently '2.8'

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/ipa_privilege/tasks/modify_ipa_privilege.yml:53:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@HaloGithub this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

HaloGithub added some commits Jun 6, 2019

@HaloGithub

This comment has been minimized.

Copy link
Author

commented Jun 6, 2019

May I know how to specify docker parameter when running docker run? Because I want to resolve some domains to localhost and docker option is -h.

Another issue is how to skip below distributions in shippable?

  • centos6
  • fedora28
  • fedora29
  • opensuse15py2
  • opensuse15
  • ubuntu1604
  • ubuntu1804

I tried adding skip/linux/centos6 and skip/centos6 in aliases file but not working.

Getting mad..

@HaloGithub HaloGithub changed the title Finish. Adding FreeIPA modules. Jun 6, 2019

HaloGithub added some commits Jun 6, 2019

@Akasurde Akasurde changed the title Adding FreeIPA modules. FreeIPA: Add new modules - ipa_permission and ipa_privilege Jun 7, 2019

@Akasurde Akasurde removed the needs_triage label Jun 7, 2019

@HaloGithub

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

May I know how to specify docker parameter when running docker run? Because I want to resolve some domains to localhost and docker option is -h.

Another issue is how to skip below distributions in shippable?

  • centos6
  • fedora28
  • fedora29
  • opensuse15py2
  • opensuse15
  • ubuntu1604
  • ubuntu1804

I tried adding skip/linux/centos6 and skip/centos6 in aliases file but not working.

Getting mad..

Finally, I add skip/docker then everything works fine.

@ansibot ansibot added the stale_ci label Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.