Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: zabbix mediatype #57488

Merged
merged 8 commits into from Jun 16, 2019

Conversation

Projects
None yet
4 participants
@rubentsirunyan
Copy link
Contributor

commented Jun 6, 2019

SUMMARY

Created a new module for interacting with Zabbix mediatypes.
API documentation

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

zabbix_mediatype

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

The test ansible-test sanity --test pylint [explain] failed with 12 errors:

lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:165:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:302:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:337:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:345:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:352:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:483:51: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:485:47: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:489:52: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:492:66: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:498:62: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:504:51: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:506:47: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test validate-modules [explain] failed with 11 errors:

lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E312 No RETURN provided
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E322 Argument 'smtp_authentication' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E322 Argument 'smtp_security' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E322 Argument 'smtp_verify_host' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E322 Argument 'smtp_verify_peer' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E324 Argument 'smtp_helo' in argument_spec defines default as ('localhost') but documentation defines default as (None)
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E324 Argument 'smtp_server' in argument_spec defines default as ('localhost') but documentation defines default as (None)
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E324 Argument 'smtp_server_port' in argument_spec defines default as (25) but documentation defines default as (None)
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E326 Argument 'attempt_interval' in argument_spec defines choices as ([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59]) but documentation defines choices as ([])
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E326 Argument 'max_attempts' in argument_spec defines choices as ([0, 1, 2, 3, 4, 5, 6, 7, 8, 9]) but documentation defines choices as ([])
lib/ansible/modules/monitoring/zabbix/zabbix_mediatype.py:0:0: E326 Argument 'max_sessions' in argument_spec defines choices as ([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99]) but documentation defines choices as ([])

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@ansibot ansibot removed the ci_verified label Jun 7, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

@Akint @D3DeFi @K-DOT @RedWhiteMiko @abulimov @akomic @cove @dj-wasabi @eikef @harrisongu @logan2211 @sookido

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@rubentsirunyan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

This is not draft anymore, so feel free to review :)

@D3DeFi

D3DeFi approved these changes Jun 14, 2019

Copy link
Contributor

left a comment

This was such a joy to look at :) Awesome work @rubentsirunyan !

LGTM

zabbix_mediatype: Removing unused import
Co-Authored-By: Dusan Matejka <D3DeFi@users.noreply.github.com>

@ansibot ansibot added community_review and removed shipit labels Jun 14, 2019

@D3DeFi

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

+1

@ansibot ansibot added shipit and removed community_review labels Jun 14, 2019

@ansibot ansibot added needs_revision and removed shipit labels Jun 16, 2019

@resmo

resmo approved these changes Jun 16, 2019

Copy link
Member

left a comment

shipit

@ansibot ansibot added shipit and removed needs_revision labels Jun 16, 2019

@resmo resmo merged commit 9e225fb into ansible:devel Jun 16, 2019

1 check passed

Shippable Run 127887 status is SUCCESS.
Details
@D3DeFi

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@resmo should I update other zabbix modules with above mentioned helper for missing deps?

@resmo

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

@D3DeFi this should be used in all modules, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.