Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module to set MOTD banner text for Pure Storage FlashArray #57500

Merged
merged 1 commit into from Jun 16, 2019

Conversation

Projects
None yet
4 participants
@sdodsley
Copy link
Contributor

commented Jun 6, 2019

SUMMARY

New module to set or delete the MOTD banner text that is shown when logging in via SSH or the GUI

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

purefa_banner.py

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@bannaych @genegr @lionmax @opslounge @raekins @sile16

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot

This comment has been minimized.

@genegr

This comment has been minimized.

Copy link

commented Jun 8, 2019

shipit

@resmo
Copy link
Member

left a comment

see comments inline, mostly low hanging fruits: check mode support and missing idempotency in state=absent

@ansibot ansibot added needs_revision and removed shipit labels Jun 9, 2019

@sdodsley sdodsley force-pushed the sdodsley:purefa_banner branch 2 times, most recently from 5981806 to 61e3626 Jun 9, 2019

@sdodsley sdodsley force-pushed the sdodsley:purefa_banner branch from 61e3626 to e3fa745 Jun 15, 2019

@resmo

resmo approved these changes Jun 15, 2019

Copy link
Member

left a comment

shipit

@ansibot ansibot added shipit and removed needs_revision labels Jun 15, 2019

@resmo resmo merged commit 0f29037 into ansible:devel Jun 16, 2019

1 check passed

Shippable Run 127787 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.