Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe_eval fix (#57188) #57501

Open
wants to merge 2 commits into
base: stable-2.8
from

Conversation

Projects
None yet
3 participants
@bcoca
Copy link
Member

commented Jun 6, 2019

  • just dont pass locals
  • also fix globals
  • added tests
  • fixed tests

(cherry picked from commit b9b0b23)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

template

bcoca added some commits Jun 6, 2019

safe_eval fix (#57188)
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23)

@bcoca bcoca force-pushed the bcoca:unsafer_28 branch from 8343a9c to f6076fe Jun 12, 2019


- name: Registering image name
set_fact:
inames: "{{ inames }} + [iname]"

This comment has been minimized.

Copy link
@felixfontein

felixfontein Jun 12, 2019

Contributor

The cherry-picked commit looks slighly different for this file.

This comment has been minimized.

Copy link
@bcoca

bcoca Jun 12, 2019

Author Member

it didnt exist in stable-2.8 so when i did initial merge i removed, but it seems to have appeared there since then

This comment has been minimized.

Copy link
@felixfontein

felixfontein Jun 12, 2019

Contributor

It got merged in #57085.

This comment has been minimized.

Copy link
@bcoca

bcoca Jun 13, 2019

Author Member

k, so it was not there so fine to remove here

This comment has been minimized.

Copy link
@felixfontein

felixfontein Jun 13, 2019

Contributor

It was there a couple of days before you created this backport. In particular, your first commit simply changes this file (i.e. does not add it). The second commit then explicitly removes this file. So removing the second commit (f6076fe) will fix this issue.

@ansibot ansibot removed the needs_triage label Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.