Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vultr: vultr_account_facts -> info #57563

Merged
merged 4 commits into from Jun 19, 2019

Conversation

Projects
None yet
4 participants
@resmo
Copy link
Member

commented Jun 8, 2019

SUMMARY

Transition from facts to info

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vultr_account_facts

ADDITIONAL INFORMATION
TASK [vultr_account_info : test get vultr account infos in check mode] **********************************************************************************************************
ok: [testhost] => {"changed": false, "vultr_account_info": {"balance": -152.97, "last_payment_amount": -250.0, "last_payment_date": "2017-04-28 12:29:50", "pending_charges": 1.31}, "vultr_api": {"api_account": "default", "api_endpoint": "https://api.vultr.com", "api_retries": 5, "api_timeout": 60}}

TASK [vultr_account_info : verify test get vultr account infos in check mode] ***************************************************************************************************
ok: [testhost] => {
    "changed": false, 
    "msg": "All assertions passed"
}

TASK [vultr_account_info : test get vultr account fact] *************************************************************************************************************************
ok: [testhost] => {"changed": false, "vultr_account_info": {"balance": -152.97, "last_payment_amount": -250.0, "last_payment_date": "2017-04-28 12:29:50", "pending_charges": 1.31}, "vultr_api": {"api_account": "default", "api_endpoint": "https://api.vultr.com", "api_retries": 5, "api_timeout": 60}}

TASK [vultr_account_info : verify test get vultr account infos] *****************************************************************************************************************
ok: [testhost] => {
    "changed": false, 
    "msg": "All assertions passed"
}

PLAY RECAP **********************************************************************************************************************************************************************
testhost                   : ok=5    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   



@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

The test ansible-test sanity --test symlinks [explain] failed with 1 error:

lib/ansible/modules/cloud/vultr/_vr_account_facts.py:0:0: broken symlinks are not allowed

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
rendering: vultr_account_info (2229 previous rendering line(s) omitted)
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 813, in <module>
    main()
  File "../bin/plugin_formatter.py", line 800, in main
    process_plugins(plugin_info, templates, outputname, output_dir, options.ansible_version, plugin_type)
  File "../bin/plugin_formatter.py", line 450, in process_plugins
    fname = module_map[module]['path']
KeyError: 'path'
make: *** [modules] Error 1

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
rendering: vultr_account_info (2238 previous rendering line(s) omitted)
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 813, in <module>
    main()
  File "../bin/plugin_formatter.py", line 800, in main
    process_plugins(plugin_info, templates, outputname, output_dir, options.ansible_version, plugin_type)
  File "../bin/plugin_formatter.py", line 450, in process_plugins
    fname = module_map[module]['path']
KeyError: 'path'
make: *** [modules] Error 1

click here for bot help

@resmo

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

waiting for #57774

@acozine

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

@resmo 57774 is merged - a rebase should get this PR passing

@ansibot ansibot added the stale_ci label Jun 18, 2019

@resmo resmo force-pushed the resmo:feature/vultr_account_facts_to_info branch from fe52695 to 73297f4 Jun 18, 2019

@ansibot ansibot removed the needs_revision label Jun 18, 2019

@ansibot ansibot added core_review and removed stale_ci labels Jun 18, 2019

@resmo resmo merged commit 6bace8a into ansible:devel Jun 19, 2019

1 check passed

Shippable Run 128302 status is SUCCESS.
Details

@resmo resmo deleted the resmo:feature/vultr_account_facts_to_info branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.