Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] acme_*: new test container, tests for IP certificates #57569

Merged
merged 1 commit into from Jun 18, 2019

Conversation

Projects
None yet
5 participants
@felixfontein
Copy link
Contributor

commented Jun 8, 2019

SUMMARY

Uses the latest ACME test container, and adds tests for IP certificates (supported in 2.8.0, but had no tests so far due to lack of appropriate test container).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

acme_certificate
test/runner/lib/cloud/acme.py

acme_*: new test container, tests for IP certificates (#57530)
* Bump container version.

* Use new URLs.

* Add IP certificate tests.

* Disable IPv6 IP from IP certificate.

Background: in CI, the ACME test container apparently has no IPv6 support.
Without IPv6 support, Pebble can't connect to validate, and thus validation
fails.

(cherry picked from commit c50a75a)
@ansibot

This comment has been minimized.

@ffdybuster

This comment has been minimized.

Copy link

commented Jun 12, 2019

bot_status

@ansibot ansibot added core_review and removed needs_revision labels Jun 12, 2019

@abadger abadger merged commit fd04094 into ansible:stable-2.8 Jun 18, 2019

1 check passed

Shippable Run 126990 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Merged for the 2.8.2 release.

@felixfontein felixfontein deleted the felixfontein:backport/2.8/57530 branch Jun 18, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

Thanks for merging!

@sivel sivel removed the needs_triage label Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.