Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable grafana_annotations callback sending annotations to multiple panels #57575

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@emschu
Copy link

commented Jun 8, 2019

SUMMARY

Enables grafana_annotations callback plugin sending annotations to multiple panels of a dashboard.

  • small refactoring of dashboardId + panelId handling
  • plugin doc modifications

The user is able to set for "panelId" whether nothing, a single integer or a list of integers separated by comma.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

grafana_annotations callback plugin

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/callback/grafana_annotations.py:280:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/callback/grafana_annotations.py:280:1: W391 blank line at end of file

click here for bot help

emschu
@rrey
Copy link
Contributor

left a comment

With that little change made it will be ok for me. Thanks for the contribution !

Show resolved Hide resolved lib/ansible/plugins/callback/grafana_annotations.py Outdated

emschu added some commits Jun 10, 2019

@emschu

This comment has been minimized.

Copy link
Author

commented Jun 10, 2019

ready_for_review

@rrey

rrey approved these changes Jun 10, 2019

Copy link
Contributor

left a comment

lgtm

@rrey

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

ship_it

@ansibot ansibot added the stale_ci label Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.