Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Fix vmware_guest_move undefined VM name error #57582

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
4 participants
@Akasurde
Copy link
Member

commented Jun 9, 2019

SUMMARY
  • Updated testcase
  • Added check mode support
  • Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/57580-vmware_guest_move-fix_undefined_name.yml
lib/ansible/modules/cloud/vmware/vmware_guest_move.py
test/integration/targets/vmware_guest_move/tasks/main.yml

@ansibot

This comment has been minimized.

VMware: Fix vmware_guest_move undefined VM name error
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

@Akasurde Akasurde force-pushed the Akasurde:i57580 branch from eac7817 to 6cf4171 Jun 9, 2019

@Akasurde Akasurde requested review from goneri and jillr Jun 10, 2019

@Akasurde Akasurde removed the needs_triage label Jun 10, 2019

@GBrawl

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

LGTM 👍

@ansibot ansibot added shipit and removed community_review labels Jun 13, 2019

@imjoseangel

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

I really like the yaml anchor in the tests. LGTM. Thanks!

@Akasurde Akasurde merged commit 00604d3 into ansible:devel Jun 13, 2019

1 check passed

Shippable Run 126691 status is SUCCESS.
Details

@Akasurde Akasurde deleted the Akasurde:i57580 branch Jun 13, 2019

@Akasurde

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

@imjoseangel @GBrawl Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.