Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman,conn: raise and exc when podman mount fails #57584

Closed

Conversation

Projects
None yet
3 participants
@TomasTomecek
Copy link
Contributor

commented Jun 9, 2019

SUMMARY

When podman mount fails, the execution continues which can result into changing the controller - mount_point variable is not set so put_files will try to copy things on controller, not container. Luckily this fails in setup phase.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/connection/podman

podman,conn: raise and exc when podman mount fails
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>

@TomasTomecek TomasTomecek force-pushed the TomasTomecek:podman-conn-fix-mount-issues branch from caf6b47 to 3a3eec6 Jun 9, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

@TomasTomecek: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

ready_for_review

@TomasTomecek

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.