Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up iosxr get_config_diff function #57589

Merged
merged 1 commit into from Jun 14, 2019

Conversation

Projects
None yet
4 participants
@pabelanger
Copy link
Contributor

commented Jun 9, 2019

SUMMARY

Fix index error in iosxr netconf tests

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iosxr_* netconf tests

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

This code is super fragile, and needs to be made more robust. This was my 20min attempt to get tests working.

@ansibot

This comment has been minimized.

Clean up iosxr get_config_diff function
This fixes an index error issue when running tests on zuul.ansible.com
for iosxr. We can fix this by getting the last element in the list.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

Pull-request updated, HEAD is now c686534

@pabelanger pabelanger force-pushed the pabelanger:temp/iosxr-get_config_diff branch from 2f3b3a2 to c686534 Jun 9, 2019

@ansibot ansibot added the small_patch label Jun 9, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 9, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot removed the needs_triage label Jun 14, 2019

@NilashishC

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 14, 2019

Build succeeded (third-party-check pipeline).

@NilashishC NilashishC merged commit 88a1fc2 into ansible:devel Jun 14, 2019

2 checks passed

Shippable Run 126719 status is SUCCESS.
Details
ansible/third-party-check third-party-check status: success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.