Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module - meraki_intrusion_prevention #57590

Open
wants to merge 8 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@kbreit
Copy link
Contributor

commented Jun 9, 2019

SUMMARY

Adds support for configuring Meraki intrusion prevention functionality.

Fixes #56402

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

meraki_intrusion_prevention

ADDITIONAL INFORMATION
  - name: Set full ruleset with check mode
    meraki_intrusion_prevention:
      auth_key: '{{auth_key}}'
      state: present
      org_name: '{{test_org_name}}'
      net_name: '{{test_net_name}} - IPS'
      mode: prevention
      ids_rulesets: security
      protected_networks:
        use_default: true
        included_cidr:
          - 192.0.1.0/24
        excluded_cidr:
          - 10.0.1.0/24
    delegate_to: localhost

TASK [meraki_intrusion_prevention : debug] *************************************
ok: [localhost] =>
  mode:
    changed: true
    data:
      idsRulesets: balanced
      mode: prevention
    failed: false
    response: OK (unknown bytes)
    status: 200

TASK [meraki_intrusion_prevention : debug] *************************************
ok: [localhost] =>
  full_check:
    changed: true
    data:
      idsRulesets: balanced
      mode: prevention
      protectedNetworks:
        excludedCidr:
        - 10.0.1.0/24
        includedCidr:
        - 192.0.1.0/24
        useDefault: true
    failed: false
    response: OK (unknown bytes)
    status: 200

kbreit added some commits May 14, 2019

IPS module mostly works
- Support ticket submitted for error in final tests
- Need new idempotency check for full test suite passage
- Documentation should be enhanced
Updated module for full functionality
- Not all limitations are taken into account
- Parameter checking needs to be improved
- Documentation needs to be updatd
- Not all integration tests work
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/meraki/meraki_intrusion_prevention.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/meraki/meraki_intrusion_prevention.py:3:1: SyntaxError:

The test ansible-test sanity --test line-endings [explain] failed with 2 errors:

lib/ansible/modules/network/meraki/meraki_intrusion_prevention.py:0:0: use "\n" for line endings instead of "\r\n"
test/integration/targets/meraki_intrusion_prevention/tasks/main.yml:0:0: use "\n" for line endings instead of "\r\n"

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.