Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new module ce lacp to manage Eth-Trunk interfaces mode #57615

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
3 participants
@xuxiaowei0512
Copy link
Contributor

commented Jun 10, 2019

SUMMARY

Specifies the working mode of an Eth-Trunk interface.
Specifies lacp preempt enable of Eth-Trunk lacp.
And other lcap options.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_lacp.py

ADDITIONAL INFORMATION

example:

tasks:

  • name: Ensure Eth-Trunk100 is created, add two members, and set to mode lacp-static
    ce_eth_trunk:
    trunk_id: 100
    members: ['10GE1/0/24','10GE1/0/25']
    mode: 'lacp-static'

  • device will show configuration:

interface Eth-Trunk 100
mode lacp-static
interface 10GE1/0/24 10GE1/0/25


@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@xuxiaowei0512, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E322 Argument 'provider' is listed in the argument_spec, but not documented in the module documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@CloudEngine-Ansible @numone213

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@xuxiaowei0512 xuxiaowei0512 marked this pull request as ready for review Jun 10, 2019

@ansibot ansibot added the stale_ci label Jun 18, 2019

@xuxiaowei0512 xuxiaowei0512 reopened this Jun 19, 2019

@ansibot ansibot removed the stale_ci label Jun 19, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 19 errors:

lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'collector_delay' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'fast_timeout' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'global_priority' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'max_active_linknumber' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'member_if' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'mode' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'preempt_delay' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'priority' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'provider' in argument_spec defines type as 'dict' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'select' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'system_id' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'timeout_type' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E337 Argument 'trunk_id' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E338 Argument 'mixed_rate_link_enable' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E338 Argument 'port_id_extension_enable' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E338 Argument 'preempt_enable' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E338 Argument 'state' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E338 Argument 'state_flapping' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lacp.py:0:0: E338 Argument 'unexpected_mac_disable' in argument_spec uses default type ('str') but documentation doesn't define type

click here for bot help

@xuxiaowei0512 xuxiaowei0512 deleted the xuxiaowei0512:dev/new/ce_lacp branch Jun 19, 2019

@xuxiaowei0512 xuxiaowei0512 restored the xuxiaowei0512:dev/new/ce_lacp branch Jun 19, 2019

@sivel sivel removed the needs_triage label Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.