Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new module to manage static route and bfd #57620

Closed

Conversation

Projects
None yet
3 participants
@xuxiaowei0512
Copy link
Contributor

commented Jun 10, 2019

SUMMARY
  • Manages the static routes and bfd linkage.
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py

ADDITIONAL INFORMATION

example:

  • name: Config an ip route-static bfd 10GE1/0/1 3.3.3.3 min-rx-interval 50 min-tx-interval 50 detect-multiplier 5
    ce_static_route_bfd:
    function_flag: 'singleBFD'
    nhp_interface: 10GE1/0/1
    next_hop: 3.3.3.3
    min_tx_interval: 50
    min_rx_interval: 50
    detect_multiplier: 5
    aftype: v4
    state: present

dvice will show command:
ip route-static bfd 10GE1/0/1 3.3.3.3 min-rx-interval 50 min-tx-interval 50 detect-multiplier 5


@xuxiaowei0512 xuxiaowei0512 changed the title add a new module to manage static roue and bfd add a new module to manage static route and bfd Jun 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@xuxiaowei0512, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:120:14: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E319 RETURN.changed.type: not a valid value for dictionary value @ data['changed']['type']. Got 'boolean'

click here for bot help

@ansibot ansibot removed the ci_verified label Jun 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@CloudEngine-Ansible @numone213

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 17 errors:

lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'bfd_session_name' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'commands' in argument_spec defines type as 'list' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'description' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'destvrf' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'detect_multiplier' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'function_flag' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'mask' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'min_rx_interval' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'min_tx_interval' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'next_hop' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'nhp_interface' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'pref' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'prefix' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'tag' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E337 Argument 'vrf' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E338 Argument 'aftype' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_static_route_bfd.py:0:0: E338 Argument 'state' in argument_spec uses default type ('str') but documentation doesn't define type

click here for bot help

@xuxiaowei0512 xuxiaowei0512 deleted the xuxiaowei0512:dev/new/ce_static_route_bfd branch Jun 18, 2019

@sivel sivel removed the needs_triage label Jun 18, 2019

@xuxiaowei0512 xuxiaowei0512 restored the xuxiaowei0512:dev/new/ce_static_route_bfd branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.