Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module ce_lldp to manage Link Layer Discovery Protocol(LLDP) #57625

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@xuxiaowei0512
Copy link
Contributor

commented Jun 10, 2019

SUMMARY

A new module ce_lldp to manage Link Layer Discovery Protocol(LLDP)

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_lldp.py

ADDITIONAL INFORMATION

sample:

  tasks:

  - name: "Configure global LLDP enable state"
    ce_lldp:
      lldpenable: enabled

remote host will show configuration:
  lldp enable
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@xuxiaowei0512, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@CloudEngine-Ansible @numone213

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

required: false
default: present
choices: ['present','absent']
provider:

This comment has been minimized.

Copy link
@xuxiaowei0512

xuxiaowei0512 Jun 12, 2019

Author Contributor

provider is unnecessary when using network_cli and will be ignored

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 13 errors:

lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'bind_name' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'fast_count' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'hold_multiplier' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'interval' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'management_address' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'mdn_notification_interval' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'notification_interval' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'provider' in argument_spec defines type as 'dict' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'restart_delay' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E337 Argument 'transmit_delay' in argument_spec defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E338 Argument 'lldpenable' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E338 Argument 'mdnstatus' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/cloudengine/ce_lldp.py:0:0: E338 Argument 'state' in argument_spec uses default type ('str') but documentation doesn't define type

click here for bot help

@xuxiaowei0512

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

Components

lib/ansible/modules/network/cloudengine/ce_lldp.py
support: community
maintainers:

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.