Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning message from grafana_annotations #57629

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@rrey
Copy link
Contributor

commented Jun 10, 2019

The Display class has no info attribute/method. The use of the method
was raising an Exception in task_queue_manager.py and displayed an
unappropriate deprecation warning.

SUMMARY

When running the grafana_annotations callback plugin the following message is displayed:

[DEPRECATION WARNING]: grafana_annotations callback, does not support setting 'options', it will work for now, but this will be required in the future and should be updated, see the 2.4 porting guide for details.. This feature will be removed in version 2.9. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

The issue comes from an attempt to use an info method on the Display class. This method does not exists.
This patch simply fix this usage and replace the use of info by debug.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

grafana_annotations

Fix deprecation warning message from grafana_annotations
The Display class has no `info` attribute/method. The use of the method
was raising an Exception in task_queue_manager and displayed an
unappropriate deprecation warning.

@rrey rrey force-pushed the rrey:fix-deprecation-warn branch from 1b338e0 to da65c5e Jun 10, 2019

@ansibot ansibot added the stale_ci label Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.