Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: vmware_dvs_host: Add vendor_specific_config #57637

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@vmwjoseph
Copy link
Contributor

commented Jun 10, 2019

SUMMARY

Add vendor specific config option. This is required to implement learnswitch functionality. https://labs.vmware.com/flings/learnswitch

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_dvs_host

ADDITIONAL INFORMATION
ok: [10.193.24.57 -> localhost] => {
    "changed": false, 
    "invocation": {
        "module_args": {
            "esxi_hostname": "10.193.24.57", 
            "hostname": "10.193.30.210", 
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", 
            "port": 443, 
            "state": "present", 
            "switch_name": "nova_dvs", 
            "username": "administrator@vsphere.local", 
            "validate_certs": false, 
            "vendor_specific_config": [
                {
                    "key": "com.vmware.netoverlay.layer1", 
                    "value": "learnswitch"
                }
            ], 
            "vmnics": [
                "vmnic0"
            ]
        }
    }
}
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@vmwjoseph, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Akasurde Akasurde requested review from Akasurde, jillr and goneri Jun 12, 2019

@Akasurde Akasurde self-assigned this Jun 12, 2019

@Akasurde Akasurde removed the needs_triage label Jun 12, 2019

@Akasurde Akasurde changed the title vmware_dvs_host: Add vendor_specific_config VMware: vmware_dvs_host: Add vendor_specific_config Jun 12, 2019

@jillr

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

Thanks for this PR @vmwjoseph. Would you be able to add integration tests for this feature?

@ansibot ansibot added the stale_ci label Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.