Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make netconf_get python3 compat (#57578) #57639

Merged

Conversation

Projects
None yet
5 participants
@danielmellado
Copy link
Contributor

commented Jun 10, 2019

SUMMARY

Junos Zuul CI Fixes backport, fixes compatibility with python3

Backported from devel

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_facts

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@danielmellado, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

pabelanger added a commit to pabelanger/ansible that referenced this pull request Jun 10, 2019

Remove hardcoded ansible user for junos_user integration tests (ansib…
…le#56452)

It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: ansible#57639
Depends-On: ansible#57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@ganeshrn
Copy link
Member

left a comment

@danielmellado Thank you for looking into this.

@ansibot ansibot removed the needs_triage label Jun 11, 2019

Make netconf_get python3 compat (#57578)
This uses to_text to ensure tostring() from lxml is decoded properly.

Depends-On: #57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit f709d2e)

@danielmellado danielmellado force-pushed the danielmellado:stable-2.8-pabelanger-junos-fix branch from 592f9d2 to e92541c Jun 11, 2019

@danielmellado

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Pull-request updated, HEAD is now e92541c

abadger added a commit that referenced this pull request Jun 17, 2019

Remove hardcoded ansible user for junos_user integration tests (#56452)
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: #57639
Depends-On: #57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

@abadger abadger merged commit d419a27 into ansible:stable-2.8 Jun 18, 2019

1 check passed

Shippable Run 127522 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Merged for the 2.8.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.