Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded ansible user for junos_user integration tests (#56452) #57650

Merged
merged 1 commit into from Jun 17, 2019

Conversation

Projects
None yet
4 participants
@pabelanger
Copy link
Contributor

commented Jun 10, 2019

SUMMARY

Backport of #56452

We don't use ansible user for testing in zuul.ansible.com. We can find this info using ansible variables.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_user tests

Depends-On: #57639
Depends-On: #57638

Remove hardcoded ansible user for junos_user integration tests (#56452)
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: #57639
Depends-On: #57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Pull-request updated, HEAD is now 2ca324b

@pabelanger pabelanger force-pushed the pabelanger:temp/junos-hardcode-user branch from eac239d to 2ca324b Jun 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

This and the 2 depends-on PRs, make junos testing on stable-2.8 green. Once we land these patches we'd like to report results back. Thanks!

https://dashboard.zuul.ansible.com/t/ansible/build/766b04e808124b209dc76b8d23228e66

@abadger abadger merged commit 07806f3 into ansible:stable-2.8 Jun 17, 2019

1 check passed

Shippable Run 126906 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Merged for the 2.8.2 release.

@sivel sivel removed the needs_triage label Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.