Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_tools handle connection issues #57661

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@agowa338
Copy link
Contributor

commented Jun 11, 2019

SUMMARY

Add exception handling to allow users to catch the connection issue within a playbook instead of throwing an python exception at them.
Fixes #57607

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_tools

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@ansibot

This comment has been minimized.

@ansibot ansibot added the module label Jun 21, 2019

@nitzmahone

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

I think we're unlikely to accept this kind of change- it seems like this is a problem that needs to be handled internally in the vmware_tools connection plugin. If the connection is in a broken state and knows it, the connection should be the one to attempt to fix it. We've resisted efforts to sprinkle transparent retry behavior around the rest of the codebase, as those things can easily get away from us and mask other problems. I won't close this PR, in case others have comments, but I'm -1 for any change that involves retry code outside the connection itself. Anything to add, @jborean93 @Akasurde ?

@agowa338

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Ok, I'll try to do it without retry logic.

@agowa338 agowa338 force-pushed the agowa338:patch-11 branch from cfff54b to 3749473 Jun 21, 2019

@agowa338 agowa338 changed the title vmware_tools handle connection issue while dcpromo/win_domain WIP: vmware_tools handle connection issue while dcpromo/win_domain Jun 21, 2019

@ansibot ansibot added the WIP label Jun 21, 2019

@agowa338 agowa338 force-pushed the agowa338:patch-11 branch from 4c7694e to b7c05d5 Jun 22, 2019

@agowa338 agowa338 changed the title WIP: vmware_tools handle connection issue while dcpromo/win_domain WIP: vmware_tools handle connection issues Jun 22, 2019

@agowa338 agowa338 force-pushed the agowa338:patch-11 branch from b7c05d5 to 5f0d824 Jun 22, 2019

@agowa338 agowa338 changed the title WIP: vmware_tools handle connection issues vmware_tools handle connection issues Jun 22, 2019

@agowa338

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

I separated the changes to the win_domain_controller module into a separate pr, as that module also required some minor polishing and those exceptions could basically happen with any connector.

So now the connection issues are handled without retry logic, is there anything else I need to change?

Also catch InvalidGuestLogin exception, as it get's also thrown when …
…trying to logging in too early on startup...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.