Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios_bgp: fixes #57666 #57667

Open
wants to merge 2 commits into
base: devel
from
Open
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -25,7 +25,8 @@ def render(self, config=None):
existing_as = None
if config:
match = re.search(r'router bgp (\d+)', config, re.M)
existing_as = match.group(1)
if match:
existing_as = match.group(1)

operation = self.params['operation']

@@ -419,7 +419,7 @@ def main():
supports_check_mode=True)

try:
result = module.edit_config(config_filter='| section bgp')
result = module.edit_config(config_filter='| section ^router bgp')
except Exception as exc:
module.fail_json(msg=to_text(exc))

@@ -6,6 +6,62 @@
ignore_errors: yes

- block:

- name: Add fake config with 'bgp' string
ios_config:
match: none
replace: block
lines:
- "no ip access-list extended BGP_ACL"
- "ip access-list extended BGP_ACL"
- "permit tcp any any eq bgp"

- name: Try delete fake bgp config
register: result
ios_bgp:
operation: delete

- assert:
that:
- 'result.changed == false'

- name: Clean fake config with 'bgp' string
ios_config:
match: none
replace: block
lines:
- "no ip access-list extended BGP_ACL"

- name: Add fake bgp-like config
ios_config:
match: none
replace: block
lines:
- "no ip access-list extended BGP_ACL_2"
- "ip access-list extended BGP_ACL_2"
- "remark router bgp 64496"
- "remark neighbor 192.0.2.10 remote-as 64496"
- "remark neighbor 192.0.2.10 shutdown"
- "remark address-family ipv4"
- "remark neighbor 192.0.2.10 activate"
- "remark exit-address-family"
- "permit tcp any any eq bgp"

- name: Try delete fake bgp-like config
register: result
ios_bgp:
operation: delete

- assert:
that:
- 'result.changed == false'

- name: Clean fake bgp-like config
ios_config:
match: none
replace: block
lines:
- "no ip access-list extended BGP_ACL_2"

- name: Configure BGP with AS 64496 and a router-id
ios_bgp: &config
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.