Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google: gcpubsub_facts -> gcpubsub_info #57668

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@felixfontein
Copy link
Contributor

commented Jun 11, 2019

SUMMARY

Renames the only non-autogenerated Google module for #57277.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gcpubsub_facts

@felixfontein felixfontein force-pushed the felixfontein:facts-info-gcpubsub_facts branch from bc24e59 to 829443a Jun 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@rambleraptor

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Thanks a lot for the PR! I'm a Google engineer that's been working on the GCP modules.

We have two new modules (gcp_pubsub_topic_facts and gcp_pubsub_subscription_facts) that are replacing the gcpubsub_facts module. We can definitely rename this module, but the goal is to deprecate it in the near future.

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

The question is whether the module should be deprecated in 2.9 or not. If it will only be deprecated later, it needs to be renamed. If it will be deprecated for 2.9, it's better to not rename it.

@felixfontein felixfontein force-pushed the felixfontein:facts-info-gcpubsub_facts branch from 829443a to 2c479c5 Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.