Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTL as a parameter to the digital_ocean_domain module #57683

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@kieranajp
Copy link

commented Jun 11, 2019

SUMMARY

Adds ttl as a parameter to this module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

digital_ocean_domain module

ADDITIONAL INFORMATION

This module uses DigitalOcean's default TTL of 1800 seconds, which is too high for my needs.

This pull request adds support for lowering that TTL.

As my Python sucks I'd appreciate someone double-checking this implementation 馃檪

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/digital_ocean_domain.py:0:0: E309 version_added for new option (ttl) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@@ -108,7 +114,7 @@ def find(self):
return False

def add(self):
params = {'name': self.domain_name, 'ip_address': self.domain_ip}
params = {'name': self.domain_name, 'ip_address': self.domain_ip, 'ttl': self.domain_ttl}
resp = self.post('domains/', data=params)

This comment has been minimized.

Copy link
@kieranajp

kieranajp Jun 11, 2019

Author

I just realised that this is using a different endpoint from the DO API than I was expecting 馃う鈥嶁檪

It would need to be changed to the Domain Records API. See Domains vs. Domain Records in the DO API docs

How should I proceed with this, should this module be changed to use those other (more configurable) endpoints, or is it a case of making a new module to more accurately reflect this separation in the API?

@ansibot ansibot added the stale_ci label Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.